Prusa Github development  

RE: Prusa Github development

Hi Florin, 

to the best of my knowledge the developers hand out on the Github pages, but I have no idea how often they look in. 

I am no Github expert...     am I correct in thinking this note is on the 4.0.5 development page?

Isn't the Mini on firmware 4.2.1 now? (I'm not a mini expert either... Lol... 

is the pull request on the correct page?

regards Joan

RE: Prusa Github development

It has been assigned by the look of it. Lots of activity on that page.

RE: Prusa Github development

Thanks Bob

regards Joan

RE: Prusa Github development

Well, the original ticket has been created in June as you can see. I got fed up with waiting for a fix and just did it myself and created a PR for it (it's a trivial fix, just one line change, I was able to do it in less than hour, out of which 45 minutes was just the set up). But somebody has to review that trivial change and merge it. It's been two days since I created the PR ( https://github.com/prusa3d/Prusa-Firmware-Buddy/pull/1063 ) and I haven't seen any activity since. Usually developers communicate via some forum. I found this: https://forum.prusa3d.com/forum/buddy-firmware-development-program/  But it says "You don't have permissions to see this page, please register or login for further information". That's not very helpful  - register where? It would have been nice to put a link there at least. 

RE: Prusa Github development

@florin Can I review your PR?

RE: Prusa Github development

@florin

Looking at it now it has been merged and it will be in the RC that they are building today. Thanks for contributing to improving the mini firmware.

RE: Prusa Github development

Hi @florin

your PR is reviewed and will be soon merged in 4.3.0 RC1 - edit - swaped numbers 

Thanks fo contributing

RE: Prusa Github development

Thank you guys for approving and merging it! I am willing to continue to contribute more fixes and improvements, time permitting. It would help me if you point me to the developers forum where I can ask more pointed questions related to the development workflow (do you tag somebody specifically for a review when you have a PR?,  how do you find out the proper reviewers?, other coding-related questions, who reviews open issues and assigns them, etc).

Sorry if I sounded a little impatient earlier, I didn't know how to get in contact with you and I was a bit frustrated by my lack of progress in trying to get somebody's attention on Github...

Thanks again and keep up the good work!

Florin

RE: Prusa Github development

@florin

I can't help you on a lot of your questions, I'm not aware of a developers forum as such. Given the introduction of the (in)famous link on the buddy board, I suspect a lot fewer people are going to get involved in building their own versions of the firmware, which will probably lead to a smaller community of developers, certainly until warranties start expiring.

I would also say that due to the COVID situation Prusa developers are working from home at the moment and it's been mentioned a few times on the live streams that this isn't as efficient as them all working on site. Looking at some of the current pull requests, many take a lot longer than 3 days to get reviewed. Please don't give up 😀 

RE: Prusa Github development

Florin,

Github is the good platform to contribute. Is great that you were able to set up your local development environment.  

Can you let me know which environment did you use?

Are you  used to work with development?

RE: Prusa Github development

@zoltan_l

Hi Zoltan,

I'm a professional software dev with more than 20 yrs experience in the industry. I've worked on very large (10-20 mil LOC) code bases, mostly in C++, Java, Scala and Python on Mac, Unix and Windows. 

I followed the instructions on Github and set my VSCode environment with CMake on KDE Neon Linux (which is based on Ubuntu 20.04 LTS).

Each team has their own rules and workflows and that's why I wanted to get in contact with the devs and find out the "ground rules" 🙂

Florin