RE: Stepper Motor Upgrades to Eliminate VFA's (Vertical Fine Artifacts)
Guy - the firmware is missing some code. It does not have the Z_MIN_POS defined, so it throws a flag when trying to verify/compile it. I added #define Z_MIN_POS 0.15 to mine and now it verifies fine.
RE: Stepper Motor Upgrades to Eliminate VFA's (Vertical Fine Artifacts)
Which file? Where in the file?
In all four variant files in my repository I see it defined.
// Travel limits after homing
#define X_MAX_POS 255
#define X_MIN_POS 0
#define Y_MAX_POS 212.5
#define Y_MIN_POS -4 //orig -4
#ifdef BMG_EXTRUDER
#define Z_MAX_POS 205 //kuo BMG height
#elifdef SKELESTRUDER
#define Z_MAX_POS 220 //Skelestruder height
#else
#define Z_MAX_POS 210 //default height
#endif
#define Z_MIN_POS 0.15
RE: Stepper Motor Upgrades to Eliminate VFA's (Vertical Fine Artifacts)
Guy's other changes pertain to stallguard tweaks, and some load distances for different extruders
There are also some tuned TMC2130 settings.
RE: Stepper Motor Upgrades to Eliminate VFA's (Vertical Fine Artifacts)
It was not in the mk3s file.
RE: Stepper Motor Upgrades to Eliminate VFA's (Vertical Fine Artifacts)
I don't know why it is missing from your copy.
It is definitely present in the GitHub files.
RE: Stepper Motor Upgrades to Eliminate VFA's (Vertical Fine Artifacts)
Universe just hates me.
I will download it again.
RE: Stepper Motor Upgrades to Eliminate VFA's (Vertical Fine Artifacts)
Oh, the missing line was in the 0.9 with LA15 section, which is now gone. What happened?
RE: Stepper Motor Upgrades to Eliminate VFA's (Vertical Fine Artifacts)
No. It was present in the 0.9 and LA15 branch as well. I verified it existed in all four variant files (two in each branch) yesterday.
But you are right, the 0.9 and LA15 branch has been deleted. The main 0.9 branch was made identical to the one with LA15 about two weeks ago. It no longer made any sense to maintain two separate, but identical branches. That addition to the main branch was noted in the main branch readme.
Deletion of the LA15 branch saves me work in code maintenance. Without the deletion, any edits to a variant file had to be replicated in three other variant files. Now, I'm back only need to change two files instead of four.
Because the LA15 branch
RE: Stepper Motor Upgrades to Eliminate VFA's (Vertical Fine Artifacts)
Thanks for the info. I did verify the line is there. Sunspots, I blame sunspots...
And easier for you is better for all of us!
RE: Stepper Motor Upgrades to Eliminate VFA's (Vertical Fine Artifacts)
I have everything transferred into a 3.8.0, but still cannot get it to compile. For that matter, I get the same compiler error if I try to compile a fresh download of Prusa's MK3 branch. I suspect the compilation issue is inside the Prusa MK3 branch files.
Is anyone else able to compile either my new branch https://github.com/guykuo/Prusa-Firmware/tree/MK3-3.8.0-with-0.9-motors-LA15-Slice-Skelestruder-BMG or the Prusa plain 3.8.0 MK3 branch?
Error I get is...
Arduino: 1.8.9 (Mac OS X), Board: "RAMBo"
wiring.c.o (symbol from plugin): In function `__vector_23':
(.text+0x0): multiple definition of `__vector_23'
sketch/heatbed_pwm.cpp.o (symbol from plugin):(.text+0x0): first defined here
/Applications/Arduino.app/Contents/Java/hardware/tools/avr/bin/../lib/gcc/avr/5.4.0/../../../../avr/bin/ld: Disabling relaxation: it will not work with multiple definitions
collect2: error: ld returned 1 exit status
exit status 1
Error compiling for board RAMBo.
RE: Stepper Motor Upgrades to Eliminate VFA's (Vertical Fine Artifacts)
I have everything transferred into a 3.8.0, but still cannot get it to compile. For that matter, I get the same compiler error if I try to compile a fresh download of Prusa's MK3 branch. I suspect the compilation issue is inside the Prusa MK3 branch files.
Is anyone else able to compile either my new branch https://github.com/guykuo/Prusa-Firmware/tree/MK3-3.8.0-with-0.9-motors-LA15-Slice-Skelestruder-BMG or the Prusa plain 3.8.0 MK3 branch?
Error I get is...
Arduino: 1.8.9 (Mac OS X), Board: "RAMBo"
wiring.c.o (symbol from plugin): In function `__vector_23':
(.text+0x0): multiple definition of `__vector_23'
sketch/heatbed_pwm.cpp.o (symbol from plugin):(.text+0x0): first defined here
/Applications/Arduino.app/Contents/Java/hardware/tools/avr/bin/../lib/gcc/avr/5.4.0/../../../../avr/bin/ld: Disabling relaxation: it will not work with multiple definitions
collect2: error: ld returned 1 exit status
exit status 1
Error compiling for board RAMBo.
No issues on my end when I customized my stock build. But I'm on linux so I just run the PF-build.sh script.
RE: Stepper Motor Upgrades to Eliminate VFA's (Vertical Fine Artifacts)
Well that pretty much puts a halt on my firmware if I can't compile it on my machine
VintagePC, could you try compiling my new branch with your tools?
RE: Stepper Motor Upgrades to Eliminate VFA's (Vertical Fine Artifacts)
Well that pretty much puts a halt on my firmware if I can't compile it on my machine
VintagePC, could you try compiling my new branch with your tools?
I'll give it a stab when I get home from work in a few hours.
RE: Stepper Motor Upgrades to Eliminate VFA's (Vertical Fine Artifacts)
I might be able to help. Make sure to delete the build dir when switching between branches or weird things can happen.
I'm planning on starting with a fresh 3.8.0-rc1 and porting your changes as a separate branch. That should make it easier to rebase onto newer Prusa releases.
Can you confirm that every single change you made in the code have a Kuo comment?
edit: I am getting the same compilation error as you on Prusa's 3.8.0-rc1. Let me try to figure that out.
RE: Stepper Motor Upgrades to Eliminate VFA's (Vertical Fine Artifacts)
Got a bit further. Looks like Prusa went to their own board definition. You can no longer use the Ultimachines Rambo board, but must load the PrusaResearch Rambo and us that as the target board.
Is the new Additional Board Manager url that needs to be put into Arduino IDE.
Then you install the Prusa version of the Rambo and select that board instead of the Ultimachines board.
RE: Stepper Motor Upgrades to Eliminate VFA's (Vertical Fine Artifacts)
I get the following error messages. I changed the language as required and I uncommented the BMG, left the X and Y uncommented, and commented out EXTRUDER_GEARRATIO_3375 and SLICETHERMISTOR and SLICEMAGNUM
Arduino: 1.8.10 Hourly Build 2019/08/12 10:33 (Windows 10), Board: "RAMBo"
In file included from sketch\Configuration.h:55:0,
from C:\Users\Cybr\Desktop\Prusa-Firmware-MK3-3.8.0-with-0.9-motors-LA15-Slice-Skelestruder-BMG\Firmware\Firmware.ino:33:
Configuration_prusa.h:174:2: error: invalid preprocessing directive #elifdef
#elifdef SKELESTRUDER //Skelestruder height
^~~~~~~
exit status 1
invalid preprocessing directive #elifdef
This report would have more information with
"Show verbose output during compilation"
option enabled in File -> Preferences.
RE: Stepper Motor Upgrades to Eliminate VFA's (Vertical Fine Artifacts)
I will add in and change to that board.
RE: Stepper Motor Upgrades to Eliminate VFA's (Vertical Fine Artifacts)
I get the following error messages. I changed the language as required and I uncommented the BMG, left the X and Y uncommented, and commented out EXTRUDER_GEARRATIO_3375 and SLICETHERMISTOR and SLICEMAGNUM
Arduino: 1.8.10 Hourly Build 2019/08/12 10:33 (Windows 10), Board: "RAMBo"
In file included from sketch\Configuration.h:55:0,
from C:\Users\Cybr\Desktop\Prusa-Firmware-MK3-3.8.0-with-0.9-motors-LA15-Slice-Skelestruder-BMG\Firmware\Firmware.ino:33:
Configuration_prusa.h:174:2: error: invalid preprocessing directive #elifdef
#elifdef SKELESTRUDER //Skelestruder height
^~~~~~~
exit status 1
invalid preprocessing directive #elifdefThis report would have more information with
"Show verbose output during compilation"
option enabled in File -> Preferences.
Use #elif instead of #elifdef; Win chokes on that, apparently. Thought we'd fixed that though, must have missed one.
RE: Stepper Motor Upgrades to Eliminate VFA's (Vertical Fine Artifacts)
I changed to the new board and still have it. No problem, I can just do a find replace and try again.
RE: Stepper Motor Upgrades to Eliminate VFA's (Vertical Fine Artifacts)
That is it, just that one line. It works once replaced.
Sketch uses 220278 bytes (86%) of program storage space. Maximum is 253952 bytes.
Global variables use 6146 bytes of dynamic memory.
I will test out the new firmware once my print is done, in about 5 hours. Printing a holder for my Dynavap - so awesome what people put on Thingiverse!